[SYCL] Don't export print_graph(std::string, bool) under -fpreview_breaking_changes
#16390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_breaking_changes` Follow-up for intel#16194. We must keep exporting it for backward ABI compatibility by default, but that isn't necessary for the next major release (which `-fpreview_breaking_changes` covers).
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
Should we also be removing the original function definition taking a string at L343 when under |
Contributor
Author
I'm dumb... The one at line 343 was the one I wanted to change, I think... Let me put it to draft and get back to it after morning coffee :) |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@Bensuo , please re-review. |
Bensuo
reviewed
Dec 18, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #16194. We must keep exporting it for backward ABI compatibility by default, but that isn't necessary for the next major release (which
-fpreview_breaking_changescovers).